From fd8315cd60017a3a469bf4b27db0fdfdb66aa630 Mon Sep 17 00:00:00 2001 From: Mikko Ahlroth Date: Sun, 8 Feb 2015 18:42:23 +0200 Subject: [PATCH] Send full page hash to google analytics and fix page commenting --- bower.json | 3 +++ src/components/ga-service/ga-service.js | 5 ++++- src/components/single-post/single-post.js | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/bower.json b/bower.json index b50bf4a..84e87a0 100644 --- a/bower.json +++ b/bower.json @@ -13,5 +13,8 @@ "lodash": "~2.4.1", "moment": "~2.8.3", "marked": "~0.3.2" + }, + "resolutions": { + "knockout": "~3.2.0" } } diff --git a/src/components/ga-service/ga-service.js b/src/components/ga-service/ga-service.js index a2703fb..9760fbc 100644 --- a/src/components/ga-service/ga-service.js +++ b/src/components/ga-service/ga-service.js @@ -21,7 +21,10 @@ define( } self.sendPageEvent = function() { - self.ga('send', 'pageview'); + self.ga('send', 'pageview', { + // Send the hash with the URL to differentiate different page hits + 'page': location.pathname + location.hash + }); }; } diff --git a/src/components/single-post/single-post.js b/src/components/single-post/single-post.js index d063ba7..1835ebd 100644 --- a/src/components/single-post/single-post.js +++ b/src/components/single-post/single-post.js @@ -74,7 +74,7 @@ define(['knockout', 'text!./single-post.html', '../db/db', 'marked', '../address } // Load disqus comments if they are in use on this page - self.useDisqus = !self.short && configService.useDisqus && (configService.pageComments || !self.post.isPage()); + self.useDisqus = !self.short && configService.useDisqus && (configService.pageCommenting || !self.post.isPage()); if (self.useDisqus) { // Wait until the post title is available